fix(integrations): render hyphenated /speckit-<name> for Droid (always-slash agent)#3688
Open
jawwad-ali wants to merge 2 commits into
Open
fix(integrations): render hyphenated /speckit-<name> for Droid (always-slash agent)#3688jawwad-ali wants to merge 2 commits into
jawwad-ali wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Droid command rendering to use its registered /speckit-<name> format.
Changes:
- Adds Droid to the always-slash agent set.
- Adds regression coverage for Droid invocation detection.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_invocation_style.py |
Registers Droid’s invocation style. |
tests/integrations/test_integration_droid.py |
Tests slash-skills detection. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
mnriem
requested changes
Jul 23, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
Contributor
Author
|
Thanks! The Copilot feedback is addressed — I added the disabled-case assertion so the test now covers both states: assert is_slash_skills_agent("droid", True) is True
assert is_slash_skills_agent("droid", False) is TrueThe Copilot thread is resolved and the change is pushed. Ready for another look when you have a moment. |
…s-slash agent)
DroidIntegration is an always-skills agent: it installs commands as
.factory/skills/speckit-<name>/SKILL.md and its build_command_invocation
returns the hyphenated /speckit-<name>. But "droid" was missing from every
_invocation_style set, so is_slash_skills_agent("droid", True) returned False
and both HookExecutor._render_hook_invocation and `specify init` next-steps
fell through to the dotted /speckit.<name> form — a command Droid never
registers.
Add "droid" to ALWAYS_SLASH_AGENTS, matching its always-skills siblings
grok/trae/zed/devin (each added there by their own integration PR; droid's
github#3587 omitted it).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address review: the test only covered ai_skills=True, which would also pass if Droid were miscategorized as CONDITIONAL_SLASH. Add the ai_skills=False assertion — True there is what distinguishes an ALWAYS_SLASH agent from a conditional one. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jawwad-ali
force-pushed
the
fix/droid-always-slash-invocation
branch
from
July 24, 2026 08:28
13878c6 to
3014244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DroidIntegrationis an always-skills agent — it installs commands as.factory/skills/speckit-<name>/SKILL.mdand itsbuild_command_invocationreturns the hyphenated/speckit-<name>. But"droid"was missing from every set in_invocation_style.py(DOLLAR_SKILLS_AGENTS,ALWAYS_SLASH_AGENTS,CONDITIONAL_SLASH_AGENTS), sois_slash_skills_agent("droid", True)returnedFalse.As a result, both
HookExecutor._render_hook_invocationandspecify init's next-steps_display_cmdfell through to the dotted/speckit.<name>form — a command Droid never registers. Hook dispatch and the printed getting-started commands pointed at nonexistent commands for Droid users.Fix
Add
"droid"toALWAYS_SLASH_AGENTS, matching its always-skills siblingsgrok/trae/zed/devin(each added to that set by its own integration PR — e.g. grok in #3535, zed in #2780; Droid's #3587 omitted it).Tests
tests/integrations/test_integration_droid.py::TestDroidIntegration::test_is_slash_skills_agent— assertsis_slash_skills_agent("droid", True) is True(fails before the fix). Full droid suite (46 tests) passes;ruffclean.AI-assisted: authored with Claude Code. I confirmed Droid is an always-skills
SkillsIntegration(hyphenatedbuild_command_invocation, nois_skills_modeoverride) and that grok/trae/zed/devin establish theALWAYS_SLASH_AGENTSprecedent.